Skip to content

883 raw annotated annotation paragraph a block looks bogus#888

Merged
Ducasse merged 4 commits intopillar-markup:devfrom
moufort:883-rawAnnotated-annotation-paragraph--aBlock-looks-bogus
Sep 30, 2024
Merged

883 raw annotated annotation paragraph a block looks bogus#888
Ducasse merged 4 commits intopillar-markup:devfrom
moufort:883-rawAnnotated-annotation-paragraph--aBlock-looks-bogus

Conversation

@moufort
Copy link
Contributor

@moufort moufort commented Sep 25, 2024

Issue #883

I don't know if it's the good way to do, but i don't now how to do with a blockClosure in paragraph of rawAnnotated:paragraph: cause I need to cut the linefeed of the String

@Ducasse
Copy link
Contributor

Ducasse commented Sep 26, 2024

This sounds good to me.

@Ducasse
Copy link
Contributor

Ducasse commented Sep 26, 2024

There is one test that is not passing

MicTextualMicrodownExporterTest
✗ #testAnnotated (3ms)
TestFailure: Got '>[!note]
label Foo bar
' instead of '>[!note]

label Foo bar

paragraph: [ super visitAnnotated: anAnnotated ]
| string textualExporter |
string := ''.
textualExporter := MicTextualMicrodownExporter new.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi est ce que tu recrees une instance de la meme classe ? car tu pourrais utiliser self.
Est ce que c'est parce que tu veux jeter le contenu?
La variable string me semble pas etre utilisee.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour le builder textWithBracket: j'ai besoin d'un String comme paramétre
Comme je n'avait que les enfants de anAnnotated, j'ai utilisé un nouveaux MicTextualMicrodownExporter et je l'ai fait visité tout les enfants afin de produire le String.
Le probléme d'utiliser self comme visiteur des enfants de anAnnotated, et qu'il va ajouter automatiquement dans son stream le contenu de ce qu'il va visiter, sans ajouter le charater '>' au début
Pour la variable String, j'ai oublié de la supprimer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok je comprends maintenant je me demandais si cela marchait avec plusieurs lignes.
J'imagine que tu as des tests.

@Ducasse Ducasse merged commit a1db8f9 into pillar-markup:dev Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants