End to end shared memory test#3
Merged
pierreglaser merged 4 commits intoresource-trackerfrom May 10, 2019
Merged
Conversation
Owner
Author
|
I am a little bit above +0 for merging this PR as it clearly shows that windows shared memory does not get leaked (as windows does not have resource_tracker tests) |
pierreglaser
commented
May 10, 2019
|
+1 for merging this. |
2016263 to
a2822a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end test to make sure that
shared_memorysegments created in process being abruptly terminated do not get leaked.The posix version of this test currently fails on master (and passes in python#13222)
The windows version of this test however does not fail on master. So as long as the
resource_trackeronly tracksSemLocksandshared_memoryobjects, it is useless for windows.