fix: add PYTHONPATH to sdk_patch.py step in update-sdks workflow #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sdk_patch.py script imports modules from pieces._vendor.pieces_os_client to test the patched enums. In GitHub Actions, the pieces package wasn't in Python's path, causing ModuleNotFoundError. This fix adds the src directory to PYTHONPATH before running sdk_patch.py, allowing Python to find and import the pieces module.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a module import error in the update-sdks workflow by adding the src directory to PYTHONPATH when executing sdk_patch.py. The script requires access to the pieces package to test patched enum classes, which wasn't available in the GitHub Actions environment without this path configuration.
Key Changes:
- Modified the SDK patching step to include
PYTHONPATHenvironment variable pointing to thesrcdirectory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The update-sdks workflow was failing at the
sdk_patch.pystep with:The
sdk_patch.pyscript imports modules frompieces._vendor.pieces_os_clientto test the patched enums. In GitHub Actions, thepiecespackage wasn't in Python's path, causing the import to fail.Solution
Added the
srcdirectory toPYTHONPATHbefore runningsdk_patch.py:PYTHONPATH="${PYTHONPATH}:${PWD}/src" python sdk_patch.pyThis allows Python to find and import the
piecesmodule from thesrc/piecesdirectory.Testing
✅ Verified locally that the command works with the PYTHONPATH set
✅ All 53+ enum patches succeed with this fix