fix ci #427
fix ci #427
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI pipeline issues by relocating the PyPI package upload step. The main changes reorganize when packages are uploaded to PyPI during the build and release workflow.
- Moved PyPI upload step from the release job to the build job
- Removed directory setup and file copying logic that is no longer needed in the new location
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Upload Packages to PyPi for release | ||
| if: inputs.deploy == true | ||
| run: |- | ||
| export POETRY_PYPI_TOKEN_PYPI=${{ secrets.pypi_token }} |
There was a problem hiding this comment.
The secret reference uses lowercase 'pypi_token' but GitHub Actions secrets are typically uppercase. This should likely be secrets.PYPI_TOKEN to match standard naming conventions, otherwise the authentication will fail if the secret is defined with uppercase naming.
| export POETRY_PYPI_TOKEN_PYPI=${{ secrets.pypi_token }} | |
| export POETRY_PYPI_TOKEN_PYPI=${{ secrets.PYPI_TOKEN }} |
| run: |- | ||
| export POETRY_PYPI_TOKEN_PYPI=${{ secrets.pypi_token }} | ||
| pip install poetry | ||
| poetry publish |
There was a problem hiding this comment.
The poetry publish command will fail because the dist directory with built packages may not exist at this point in the workflow. The removed code at line 457-458 explicitly created the dist directory and copied packages into it, but this logic has been removed without ensuring packages are available in the expected location.
No description provided.