Fix details inside drop-down being rendered as dropdown#615
Merged
lucaslarroche merged 1 commit intopicocss:devfrom Mar 9, 2025
Merged
Fix details inside drop-down being rendered as dropdown#615lucaslarroche merged 1 commit intopicocss:devfrom
lucaslarroche merged 1 commit intopicocss:devfrom
Conversation
Given a dropdown that contains an accordion within it, the accordion renders as a dropdown because the summary selector also selects the children of a dropdown element. This fixes that so it renders as expected.
```
<details class="dropdown">
<summary> Select a phase of matter... </summary>
<ul>
<li>
<details>
<summary> This is a dropdown option </summary>
<ul>
<li><label><input type="radio" name="phase" value="gas"> Gas </label></li>
<li><label><input type="radio" name="phase" value="plasma"> Plasma </label></li>
</ul>
</details>
</li>
</ul>
</details>
```
Member
|
Thanks @mwargan for spotting this and providing a fix! Nice addition! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a dropdown that contains an accordion within it, the accordion renders as a dropdown because the summary selector also selects the children of a dropdown element. This fixes that so it renders as expected.
Note this fix also more closely conforms with the HTML spec https://html.spec.whatwg.org/multipage/interactive-elements.html#the-summary-element as the
summaryelement should be used in the context "As the first child of a details element."