fix: don't count hidden rows in table stripes#585
Merged
lucaslarroche merged 1 commit intopicocss:devfrom Mar 9, 2025
Merged
Conversation
nstringham
approved these changes
Sep 22, 2024
Member
|
Thanks @feored for this great addition, and sorry for the delay! |
Member
|
Hey @feored, I initially tested this and it seemed to work fine, but after releasing and testing again, it’s not behaving as expected. For peace of mind, I’m reverting it for now. Appreciate your contribution, and I’ll revisit this later if we can find a way to make it work reliably across all cases! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiding rows of a table using the
hiddenglobal attribute can screw up the striping because they are still counted in the odd/even rows.This fix is straight from the MDN.