Remove requirement for hardcoded 'Index.html' in featureSearch.js#541
Merged
dirkrombauts merged 1 commit intopicklesdoc:developfrom Aug 27, 2018
Merged
Remove requirement for hardcoded 'Index.html' in featureSearch.js#541dirkrombauts merged 1 commit intopicklesdoc:developfrom
dirkrombauts merged 1 commit intopicklesdoc:developfrom
Conversation
Member
|
Thank you for your contribution! |
Merged
Member
|
Released in version 2.20.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the generated
Index.htmlwas renamed, feature search and/or any navigation using the URLs generated by the script resulted in a 404 error.After this change the generated output file can be renamed to any filename without breaking the navigation.
As a side effect, the JavaScript warnings on the console at line 55 are gone, too.