Skip to content

Fix for the special characters in Scenario Outline.#506

Closed
DominikBaran wants to merge 12 commits intopicklesdoc:developfrom
DominikBaran:develop
Closed

Fix for the special characters in Scenario Outline.#506
DominikBaran wants to merge 12 commits intopicklesdoc:developfrom
DominikBaran:develop

Conversation

@DominikBaran
Copy link
Copy Markdown

@DominikBaran
Copy link
Copy Markdown
Author

DominikBaran commented Feb 5, 2018

@dirkrombauts : hello Dirk. This is small issue fix.
I realized that special characters in the Scenario Outline title were not supported so all the tests listed below failed:
Scenario Outline: I'm Dominik
Scenario Outline: Dominik (this is my name)
Scenario Outline Dominik - it is me

I fix that so please take a look if you like that fix and merge it if the answer is "yes"

It's only small fix so no unit tests update is needed.

Cheers,
D

@dirkrombauts
Copy link
Copy Markdown
Member

Hi,

Thanks for your contribution. I can't merge it yet, because

  1. The entry in the change log seems to be about an old pull request (502) instead of this one
  2. I disagree about there being no need for a unit test. If there is a bug, I want a unit test that shows the bug is solved.

Cheers!

@DominikBaran
Copy link
Copy Markdown
Author

@dirkrombauts : thanks for your comment.
Yeah i can see my source tree did something really strange during the merge. Let me close that one and re-open that with additional unit test(s) added for the fix.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants