Try to use the CLI password for logins#392
Merged
DL6ER merged 3 commits intoPADD_FTLv6from Jun 30, 2024
Merged
Conversation
5 tasks
rdwebdesign
requested changes
Jun 21, 2024
Member
|
Tested with and without disabled = prompts for password and then works 👍 Happy to approve once suggestions resolved |
rdwebdesign
approved these changes
Jun 22, 2024
PromoFaux
approved these changes
Jun 27, 2024
yubiuser
requested changes
Jun 29, 2024
Member
yubiuser
left a comment
There was a problem hiding this comment.
Could you please rebase on latest PADD_FTLv6.
I noticed that the status codes in DeleteSession do not match them in #247 and the current documentation https://ftl.pi-hole.net/development-v6/docs/#delete-/auth
Signed-off-by: DL6ER <dl6er@dl6er.de>
…e current user) Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Member
Author
|
Sure, this PR would only merge the |
yubiuser
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR accompanies PR pi-hole/FTL#1999
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.