Skip to content

Self-contained DNSSEC CI tests#2014

Merged
DL6ER merged 1 commit intodevelopment-v6from
test/internal-dnssec
Jul 22, 2024
Merged

Self-contained DNSSEC CI tests#2014
DL6ER merged 1 commit intodevelopment-v6from
test/internal-dnssec

Conversation

@DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 22, 2024

What does this implement/fix?

See title. This is implemented by defining two internal DNSSEC zones in our CI tests - one for which we add the trust-anchor (SECURE) and one were not (BOGUS). This is a final solution to the recurring issues we have every now and then with external DNSSEC providers. The entire code is dynamic, i.e., the zones are always newly created so there are no problems with expiry, etc.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team July 22, 2024 12:11
@DL6ER DL6ER mentioned this pull request Jul 22, 2024
5 tasks
@DL6ER DL6ER merged commit ac1db97 into development-v6 Jul 22, 2024
@DL6ER DL6ER deleted the test/internal-dnssec branch July 22, 2024 14:08
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants