Skip to content

Codespell the code, add configuration and workflow for it so no typo sneaks in#436

Merged
smoia merged 5 commits intophysiopy:masterfrom
yarikoptic:enh-codespell
Apr 13, 2023
Merged

Codespell the code, add configuration and workflow for it so no typo sneaks in#436
smoia merged 5 commits intophysiopy:masterfrom
yarikoptic:enh-codespell

Conversation

@yarikoptic
Copy link
Copy Markdown
Contributor

One decision was "in the code" - please check commit 3e8f68e

We could alternatively exclude "wasn" word but I decided to go this way.
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2023

Codecov Report

Merging #436 (1e602a8) into master (4464c84) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files           8        8           
  Lines         966      966           
=======================================
  Hits          916      916           
  Misses         50       50           
Impacted Files Coverage Δ
phys2bids/cli/run.py 96.55% <ø> (ø)
phys2bids/io.py 96.63% <ø> (ø)
phys2bids/phys2bids.py 90.10% <ø> (ø)
phys2bids/physio_obj.py 94.03% <ø> (ø)
phys2bids/slice4phys.py 92.10% <ø> (ø)
phys2bids/viz.py 95.18% <ø> (ø)
phys2bids/bids.py 98.05% <100.00%> (ø)
phys2bids/utils.py 98.09% <100.00%> (ø)

Copy link
Copy Markdown
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoia
Copy link
Copy Markdown
Member

smoia commented Apr 13, 2023

Before I merge, do you know if we can add codespell to pre-commit instead of running it in Github?

@smoia
Copy link
Copy Markdown
Member

smoia commented Apr 13, 2023

Yes, we can - I'll merge this for the moment, but it's good to remember to add it directly to pre-commit instead once that will be in the works!

@smoia smoia merged commit b60ee00 into physiopy:master Apr 13, 2023
@smoia smoia added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Apr 13, 2023
@smoia
Copy link
Copy Markdown
Member

smoia commented Apr 26, 2023

🚀 PR was released in 2.8.4 🚀

@smoia smoia added the released This issue/pull request has been released. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants