Skip to content

Add template for AclProviderInterface#92

Closed
VincentLanglet wants to merge 7 commits intophpstan:masterfrom
VincentLanglet:aclProvider
Closed

Add template for AclProviderInterface#92
VincentLanglet wants to merge 7 commits intophpstan:masterfrom
VincentLanglet:aclProvider

Conversation

@VincentLanglet
Copy link
Copy Markdown
Contributor

@VincentLanglet VincentLanglet commented Aug 13, 2020

Hi @ondrejmirtes

If I understand correctly template and I didn't make any mistake, this PR seems better than symfony/security-acl#60.

By the way I have two others questions:

  • WDYT about supporting directory in the stubFiles config ? This way the following code would be enough.
stubFiles:
    - stubs/
  • WDYT about using the same directory structure than Symfony inside the stub directory ? There will be more and more file, and it can be easier to find them if we follow the namespace.

@VincentLanglet VincentLanglet mentioned this pull request Aug 13, 2020
Closed
ondrejmirtes
ondrejmirtes requested changes Aug 14, 2020
View reviewed changes
@VincentLanglet VincentLanglet force-pushed the aclProvider branch 6 times, most recently from 5341349 to 6503151 Compare August 16, 2020 21:15
@VincentLanglet
Copy link
Copy Markdown
Contributor Author

VincentLanglet commented Aug 16, 2020 •
edited
Loading

I need phpstan/phpstan#3111 first

Opened phpstan/phpstan-src#301

@ondrejmirtes ondrejmirtes mentioned this pull request Aug 17, 2020
Merged
@VincentLanglet
Copy link
Copy Markdown
Contributor Author

VincentLanglet commented Sep 27, 2020

@ondrejmirtes I removed the findAcls annotation since it requires the next phpstan major.
So this PR is now ready to merge.

@VincentLanglet VincentLanglet force-pushed the aclProvider branch 3 times, most recently from 82b4158 to 297b4bb Compare December 13, 2020 21:19
@VincentLanglet
Copy link
Copy Markdown
Contributor Author

VincentLanglet commented Dec 13, 2020

@ondrejmirtes I rebase master ; this PR is ready to merge

@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented Dec 27, 2020

Hi, I'm sorry, but this PR does too many things at once and it's unlikely to be merged.

  1. Adds AclProviderInterface stub - should be in a separate PR.
  2. Moves stubs into subdirectories - should be a separate PR.
  3. Adds CS to stubs - not interested in this, sorry, as other repositories don't have this and there's little value in that.

@VincentLanglet VincentLanglet mentioned this pull request Apr 18, 2021
Merged
@VincentLanglet VincentLanglet mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VincentLanglet @ondrejmirtes