Fix Envelope::all() return type#309
Merged
ondrejmirtes merged 1 commit intophpstan:1.2.xfrom Nov 4, 2022
Merged
Conversation
fe3f3e8 to
84133fe
Compare
enumag
commented
Nov 4, 2022
84133fe to
da987d1
Compare
enumag
commented
Nov 4, 2022
2488bbc to
65d133d
Compare
Contributor
Author
|
Hmm... except that Also some tests are now failing on this: |
65d133d to
cd3250a
Compare
Member
|
Require PHPStan 1.9 |
cd3250a to
9be4d30
Compare
Contributor
Author
|
Okay... I'll go and assume that the method should be covered by compatibility promise since you recommended it's usage... see phpstan/phpstan-src#1967. |
ondrejmirtes
requested changes
Nov 4, 2022
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
You can require PHPStan ^1.9.1 now.
9be4d30 to
098a9f3
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that my fix from #308 wasn't working so I looked deeper into it. Trying a better fix now.