Add stub for mysqli_stmt properties#700
Add stub for mysqli_stmt properties#700ondrejmirtes merged 1 commit intophpstan:masterfrom morozov:mysqli-stub
Conversation
stubs/mysqli.stub
Outdated
There was a problem hiding this comment.
I think this should be smth like
@var array<int, array{errno: int, sqlstate: string, error: string}>
stubs/mysqli.stub
Outdated
There was a problem hiding this comment.
Shouldn't this be 0|positive-int as well as is $param_count?
stubs/mysqli.stub
Outdated
There was a problem hiding this comment.
I guess this one should also never be negative?
stubs/mysqli.stub
Outdated
There was a problem hiding this comment.
If I interpret the docs right, I think this will never be empty, as 00000 means no error
Additionally, update the corresponding procedural style aliases.
|
@herndlm thanks for the recommendations. I initially intended to keep the changes scoped to the original issue and keep the signatures consistent with their existing procedural style aliases. |
Yeah I just wanted to suggest things, but I'm still too new here, so do take my comments with a grain of salt please! |
|
Thank you both! :) |
See #692.