Support array as template type bound.#673
Merged
ondrejmirtes merged 4 commits intophpstan:masterfrom Sep 16, 2021
drupol:feat/support-array-as-template-type-bound
Merged
Support array as template type bound.#673ondrejmirtes merged 4 commits intophpstan:masterfrom drupol:feat/support-array-as-template-type-bound
ondrejmirtes merged 4 commits intophpstan:masterfrom
drupol:feat/support-array-as-template-type-bound
Conversation
This is the initial commit that has been inspired by this commit: 4e7d6c1
ondrejmirtes
requested changes
Sep 16, 2021
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
This looks solid! Please do these two changes, mark it as ready and I'll merge it :)
Contributor
Author
|
@ondrejmirtes If you want, we can wait a bit more and I'll submit the same kind of stuff for WDYT ? |
Member
|
@drupol I think all of those are already supported. |
ondrejmirtes
approved these changes
Sep 16, 2021
Member
|
Thank you! |
Contributor
Author
|
Excellent! Thanks for the support into making this :) |
Contributor
|
Thanks for this PR. I think this is going to help quite a bit in one of the projects I'm working on. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: