Make filter_var() return non-empty-string if input is non-empty #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I see the test error but not sure what it's tripping on. |
Member
|
This change needs a test in NodeScopeResolverTest. |
Member
|
Thank you! |
Contributor
|
Hey, this is probably incorrect for the SANITIZE versions, as they remove the 'wrong' parts, e.g. https://3v4l.org/PXaQ7 |
Member
|
@BackEndTea Please send a PR or open an issue. |
Contributor
Author
|
@BackEndTea Yeah I realized you are probably correct. I can try to handle the finer details in another PR if you haven't already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#5526. Let me know if there's anything else I'd need to add.