Skip to content

mb_str_split() / str_split() always returns non-empty-array#633

Merged
ondrejmirtes merged 6 commits intophpstan:masterfrom
staabm:str-split
Aug 23, 2021
Merged

mb_str_split() / str_split() always returns non-empty-array#633
ondrejmirtes merged 6 commits intophpstan:masterfrom
staabm:str-split

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Aug 20, 2021 •
edited
Loading

@staabm staabm mentioned this pull request Aug 20, 2021
Merged
@staabm staabm changed the title (mb_)?str_split() always returns non-empty-array (mb_)?str_split() always returns non-empty-array Aug 20, 2021
staabm
staabm commented Aug 20, 2021
View reviewed changes
tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php Outdated
Copy link
Contributor Author

@staabm staabm Aug 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interessting.. sometimes a type including braces is produced, and sometimes without

Copy link
Member

@ondrejmirtes ondrejmirtes Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan-src/src/Type/UnionType.php

Lines 150 to 168 in 119facc

$joinTypes = static function (array $types) use ($level): string {
$typeNames = [];
foreach ($types as $type) {
if ($type instanceof ClosureType || $type instanceof CallableType) {
$typeNames[] = sprintf('(%s)', $type->describe($level));
} elseif ($type instanceof IntersectionType) {
$intersectionDescription = $type->describe($level);
if (strpos($intersectionDescription, '&') !== false) {
$typeNames[] = sprintf('(%s)', $type->describe($level));
} else {
$typeNames[] = $intersectionDescription;
}
} else {
$typeNames[] = $type->describe($level);
}
}
return implode('|', $typeNames);
};

staabm
staabm commented Aug 20, 2021
View reviewed changes
staabm added 3 commits August 20, 2021 13:42
@staabm
(mb_)?str_split() always returns non-empty-array
6bbca56
@staabm
fix tests
7fefa4e
@staabm
remove dead code
dbfc9f7 
Call to function is_array() with array<int, string>&nonEmpty will always evaluate to true.
staabm
staabm commented Aug 20, 2021
View reviewed changes
@staabm staabm changed the title (mb_)?str_split() always returns non-empty-array mb_str_split() / str_split() always returns non-empty-array Aug 23, 2021
@staabm
Copy link
Contributor Author

staabm commented Aug 23, 2021

@ondrejmirtes fixed remaining php8 error. should be good to go

@ondrejmirtes ondrejmirtes merged commit 8bf2fe0 into phpstan:master Aug 23, 2021
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Aug 23, 2021

Thank you!

@staabm staabm deleted the str-split branch August 27, 2021 11:56
@herndlm herndlm mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes left review comments

+1 more reviewer

@voku voku voku left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@staabm @ondrejmirtes @voku @clxmstaab