Fix phpstan/phpstan#13526: False positive with array_key_exists and union types#5114
Merged
staabm merged 1 commit intophpstan:2.1.xfrom Mar 1, 2026
Merged
Fix phpstan/phpstan#13526: False positive with array_key_exists and union types#5114staabm merged 1 commit intophpstan:2.1.xfrom
staabm merged 1 commit intophpstan:2.1.xfrom
Conversation
staabm
commented
Mar 1, 2026
|
|
||
| if ($originalExprType->equals($nativeType)) { | ||
| $newType = TypeCombinator::intersect($type, $originalExprType); | ||
| if ($newType->isConstantScalarValue()->yes() && $newType->equals($originalExprType)) { |
Contributor
Author
There was a problem hiding this comment.
this code was added in the past to improve performance.
after measuring again it seems we no longer need this logic, as it seems we fixed the bottleneck somewhere else.
before this PR
➜ phpstan-src git:(2.1.x) hyperfine 'vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php' --runs=3 --warmup=1
Benchmark 1: vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php
Time (mean ± σ): 15.854 s ± 0.095 s [User: 15.462 s, System: 0.383 s]
Range (min … max): 15.749 s … 15.934 s 3 runs
with deleted logic
➜ phpstan-src git:(bug13526) hyperfine 'vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php' --runs=3 --warmup=1
Benchmark 1: vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php
Time (mean ± σ): 15.840 s ± 0.213 s [User: 15.455 s, System: 0.375 s]
Range (min … max): 15.642 s … 16.065 s 3 runs
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13526
Related to #3933