Prevent TypeCombinator::intersect() calls in MutatingScope-> specifyExpressionType()#5048
Merged
ondrejmirtes merged 5 commits intophpstan:2.1.xfrom Feb 26, 2026
Merged
Prevent TypeCombinator::intersect() calls in MutatingScope-> specifyExpressionType()#5048ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
TypeCombinator::intersect() calls in MutatingScope-> specifyExpressionType()#5048ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
Member
|
Oh nice, can't wait to merge this! |
…fyExpressionType()`
bbc187b to
94008eb
Compare
94008eb to
ec80227
Compare
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Feb 26, 2026
| $reportUnmatched = (bool) ($uniquedExpandedIgnoreErrors[$key]['reportUnmatched'] ?? $this->reportUnmatchedIgnoredErrors); | ||
| if (!$reportUnmatched) { | ||
| $reportUnmatched = $ignoreError['reportUnmatched'] ?? $this->reportUnmatchedIgnoredErrors; | ||
| } |
Member
There was a problem hiding this comment.
How does this change relate to the rest?
Contributor
Author
There was a problem hiding this comment.
the previous expression
($uniquedExpandedIgnoreErrors[$key]['reportUnmatched'] ?? $this->reportUnmatchedIgnoredErrors) || ($ignoreError['reportUnmatched'] ?? $this->reportUnmatchedIgnoredErrors)
errored with
Only booleans are allowed in ||, mixed given on the right side.
ondrejmirtes
approved these changes
Feb 26, 2026
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running
phpstan analyse --debug src/on Wordpress:before this PR:
TypeCombinator::intersectinvoked 37100xafter this PR:
TypeCombinator::intersectinvoked 1146xsaves 3-5 seconds which translates to a 2-3% perf improvement
TypeCombinator::intersectis the most expensive part ofMutatingScope-> specifyExpressionType()in WP:requires https://github.com/phpstan/phpstan-src/pull/5047/files