fix .gitattributes for php-file line-ending to LF (for windows compat)#50
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Mar 15, 2020
Merged
fix .gitattributes for php-file line-ending to LF (for windows compat)#50ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
Closed
Contributor
|
Can you try to launch the CI again? I believe test will break because the issue appear with other file extensions |
otherwise phpstan cannot be build on windows when core.autocrlf is enabled
Contributor
Author
|
rebased, lets see. |
Contributor
|
Uh, weird, the test 6 (PHPStan\Rules\PhpDoc\InvalidPhpDocTagValueRuleTest::testRule) still complains about \r\n... I'd have expected this to be resolved by your commit... |
Contributor
|
Would be nice to have .editorconfig file too. |
Contributor
Author
please open a separate issue to discuss this topic |
0786c63 to
9395d76
Compare
fc58142 to
72d7c8d
Compare
Member
|
Thank you. I just arrived to the same conclusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise phpstan cannot be build on windows when
core.autocrlfis enabled.(because all files get checked out with CRLF then, and the build fast-exists because of CS issues)
I wasnt able to build the project on windows when git is configured using
core.autocrlf=truehopefully this will fix it.