Split MutatingScope->resolveType() into smaller methods#4759
Merged
ondrejmirtes merged 7 commits intophpstan:2.1.xfrom Jan 15, 2026
Merged
Split MutatingScope->resolveType() into smaller methods#4759ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
ondrejmirtes merged 7 commits intophpstan:2.1.xfrom
Conversation
staabm
commented
Jan 15, 2026
Comment on lines
+1656
to
+1657
| $callType = $this->getStaticCallType($node); | ||
| if ($callType !== null) { |
Contributor
Author
There was a problem hiding this comment.
we could prevent this null-check pattern, but for now I translated the code 1:1.
it did not always return in this cases before but let it fall thru to the below return new Mixed at the very end of the method
Member
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to get better blackfire profiles, I have splitted the biggest portions of resolveType() method into separate methods.
no functional changes
before this PR profiles showed we are spending most of the time in resolveType() but not where exactly:
my thesis is, that time spent on resolving types highly depends on the specific expression. to ease finding meaningfull bottlenecks code is separated into more named and independent building blocks (methods), which show up separately in profiles (after PR):
(see less tiny "down arrows" below the resolveType() box, which means we see better how time distributes from there.