MemoizingReflectionProvider->hasClass() is case-insensitive#4750
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Jan 13, 2026
Merged
MemoizingReflectionProvider->hasClass() is case-insensitive#4750ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
Conversation
Contributor
Author
|
the out-of-memory errors are unrelated to this change. I had a look into it, and it seems most of the memory regression we currently see on 2.1.x is related to a increase in resultCache.php size 
the biggest part of the cache might not even be related to phpstan-src itself: shipmonk-rnd/dead-code-detector#287 (removing dead-code-detector shrinks the resultCache.php by ~65%) https://blackfire.io/profiles/90337c83-aba6-4c80-853d-547f0ac566f2/graph |
Contributor
Author
|
the above comment only holds for the main process alone. running with 
https://blackfire.io/profiles/25009815-b33e-41f1-87d0-3cd594971d8e/graph |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since
MemoizingReflectionProvider->getClass()andMemoizingReflectionProvider->getClassName()work on a lowercased string, I thinkMemoizingReflectionProvider->hasClass()should work the same way to provide consistent results