Skip to content

Ignore by identifier instead of regex error pattern#4652

Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
staabm:eff
Dec 23, 2025
Merged

Ignore by identifier instead of regex error pattern#4652
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
staabm:eff

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Dec 22, 2025 •
edited
Loading

regex re-validation/AST-parsing currently is the slowest parts in some tests.

can be seen in

➜  cat foo.php 
<?php

class Foo
{

        public function doFoo(DateTimeImmutable $d): void
        {
                $a = $d->format('j. n. Y');
        }

}

➜  blackfire run /opt/homebrew/bin/php bin/phpstan analyze foo.php --debug
grafik

@ondrejmirtes ondrejmirtes merged commit 6ad4367 into phpstan:2.1.x Dec 23, 2025
366 of 369 checks passed
@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented Dec 23, 2025

Thank you!

@staabm staabm deleted the eff branch December 23, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes