Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Dec 9, 2025
Comment on lines
+117
to
+130
| - | ||
| message: '#^Parameter \#3 of function sprintf is expected to be string by placeholder \#2 \("%%s"\), string\|false given\.$#' | ||
| count: 1 | ||
| path: ../src/Cache/FileCacheStorage.php | ||
|
|
||
| - | ||
| message: '#^Parameter \#3 of function sprintf is expected to be string by placeholder \#2 \("%%s"\), string\|false given\.$#' | ||
| count: 1 | ||
| path: ../src/Rules/Cast/InvalidCastRule.php | ||
|
|
||
| - | ||
| message: '#^Parameter \#2 of function sprintf is expected to be string by placeholder \#1 \("%%s"\), string\|false given\.$#' | ||
| count: 1 | ||
| path: ../src/Rules/ClassForbiddenNameCheck.php |
Contributor
Author
There was a problem hiding this comment.
I tried to make the type inference more useful, but in the end everything I did which fixed php 7.x errors, created new php8 errors.
therefore added php7.x only ignores and called it a day
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes PHP 7.4 build errors