I don't want this huge refactoring. I don't think it makes sense to support Foo::* in an array shape key, because the result would no longer be ConstantArrayType, but ArrayType only.

The handling of Foo::BAR in an array shape key needs new code, not reusing of an existing code. For example supporting enums does not make sense there either.

Also, I realized that support for static:: is currently insufficient. It's not going to do what people expect in subclasses. But that's a story for another day.

Ok so I tried another way.

I still created a method resolveArrayShapeOffsetType because there is a lot of early return in the ConstFetchNode handling code.

Then I used a simpler version for the ConstFetchNode by

• removing * support
• removing Enum support

Thank you.