Merged
Conversation
a58bba7 to
8fb3b07
Compare
staabm
reviewed
Aug 9, 2025
Contributor
staabm
left a comment
There was a problem hiding this comment.
Do we have a test somewhere which asserts the types for array_is_list(mixed)?
Contributor
Author
Dunno, but what do you have in mind ? I added a test. |
Contributor
|
Looks good - just making sure we have it covered |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#9734
I'll need your decision on the condition to chose in ArrayType::tryRemove @ondrejmirtes
We could have
but it means that now a
will infer a non empty array for the
falsecase.It could make sens since in order to say that all the values are not string, it require to access to at least one value.
If preferred we could restrict such behavior to the list with an extra
$typeToRemove->isList()->yes()check.Or, to just solve
array_is_list; the check can be something like$typeToRemove->describe(...) === 'list'...