Remove some Ds stubs for functionMap#4218
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Aug 8, 2025
Merged
Conversation
837f01a to
ec5b5df
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same idea than #4185
I checked the signature one by one.
More could be removed when PHPStorm will be fixed
JetBrains/phpstorm-stubs#1776
Reflection goldent test is lot of
Wanted, there is a
@throwson the method.And one
Then I discover there is also an
ext-dsstub file in PHPStan so I updated it and now the change is an improvementIn another PR (and after PHPStorm PR will be merged), I'll try to get rid of the
ext-ds.stub.