Move isOffsetAccessLegal to MaybeOffsetAccessibleTypeTrait#4205
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Aug 5, 2025
Merged
Move isOffsetAccessLegal to MaybeOffsetAccessibleTypeTrait#4205ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
Conversation
Member
|
I'm fine with this, although I'm not a fan of these traits at all. I can tolerate them, but I'd really like some custom rules around them (like that if a class is using the trait, it has to use the whole trait and not override any of its methods). |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there a reason for not having this offset-related method in the MaybeOffsetAccessibleTypeTrait when all the implementation returns maybe (?)