Add non regression test for 4993#4182
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Aug 30, 2025
Merged
Conversation
7f717b0 to
577baa7
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the issue phpstan/phpstan#4993 is unclear to me
fgetcsvreturn type; never returns null since PHP8 #3712)Also the issue talk about the fact the returned array is supposed to be non-empty ; which seems true and supported by psalm https://psalm.dev/r/3176073f08 so I updated the definition.
So I think that
Closes phpstan/phpstan#4993