Add non regression test for 3761#4176
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Aug 30, 2025
Merged
Conversation
Member
|
Please reference the issue with "Closes ..." in the PR description. |
Member
|
Also I don't really get it - playground still reports the error https://phpstan.org/r/b888b1ec-063b-49dc-8db8-daa1a0495200, how could you add a regression test if it still needs fixing? |
Contributor
Author
I edited to change into to show what would happen with the previous understanding of PHPStan. (and what message we would have got, and therefor in which testCase i have to put the test) |
Contributor
Author
Sorry, I forgot, I added the phpstan/phpstan#3761 reference. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules about unreachable branch was removed in
7d74a63...cc7ff8b
The error doesn't exists anymore
https://phpstan.org/r/788cdf82-69e5-450b-8851-f475793aadcc
I added the test regression to ensure we won't get the following error
https://phpstan.org/r/b888b1ec-063b-49dc-8db8-daa1a0495200
Closes phpstan/phpstan#3761