fix unnecessary wrapping in TableErrorFormatter#4170
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Jul 27, 2025
Merged
fix unnecessary wrapping in TableErrorFormatter#4170ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
Conversation
Fixes #13317
Member
|
Thank you. Please continue sending fixes for bigs that currently affect PHPStan. And queue them as Symfony PRs. So that when we're able to update Symfony Console, we'll be able to remove all patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13317
The change was submitted to symfony in symfony/symfony#61268.
This time I tested the changes with a large project that I have available (~15k PHPStan errors) in two terminal sizes (94 and 382). And I did found one more regressions (first one is with 2.1.18 and the second one is with this PR, don't mind the ✏️ - I'm using spaces for the editor link):
As you can see the link is broken (i.e. when I click it it goes to the clipped URL) at this particular size (as well as any smaller size). Removing
<fg=cyan>from it would fix the issue. Alternatively, it could be shortened. What do you think? I'm not particularly eager to continue fixing more symfony/console issues until the previous PRs are accepted. 😅