Introduce rawMessage key in ignoreErrors#4111
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Sep 10, 2025
Merged
Conversation
5181c1f to
7defb25
Compare
ondrejmirtes
requested changes
Aug 30, 2025
7defb25 to
d0dd802
Compare
d0dd802 to
c8329e5
Compare
c8329e5 to
9aec04f
Compare
Contributor
Author
|
In a follow-up PR, I would like to change the baseline generation to use |
Member
|
Thank you! Yes, the change should be part of bleeding edge. Since both BaselinePhpErrorFormatter and BaselineNeonErrorFormatter are instantiated in AnalyseCommand, you should add a new featureToggles parameter and fetch it there through |
Contributor
|
This is a great improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#11178 (comment)
This pull request introduces the
rawMessagekey inignoreErrorsfor non-regex raw error messages: