Fix callable-string must be non-empty-string#3983
Fix callable-string must be non-empty-string#3983ondrejmirtes merged 1 commit intophpstan:1.12.xfrom
Conversation
ondrejmirtes
left a comment
There was a problem hiding this comment.
Instead of this approach, please explore modifying IntersectionType::isNonEmptyString() based on $this->isString()->yes() and $this->isCallable()->yes(). Thanks.
|
might also be worth checking whether we have a similar problem with |
4196540 to
b5af16b
Compare
@ondrejmirtes I tried to implement your suggestion. Have a look please. |
|
This pull request has been marked as ready for review. |
Let's do it in another issue, please. As I see the logic for arrays is completely different. |
|
Thank you! |
Fixes phpstan/phpstan#12979