Fix for handling non-stringable types in dynamic access#3885
Closed
zonuexe wants to merge 4 commits intophpstan:2.1.xfrom
Closed
Fix for handling non-stringable types in dynamic access#3885zonuexe wants to merge 4 commits intophpstan:2.1.xfrom
zonuexe wants to merge 4 commits intophpstan:2.1.xfrom
Conversation
ondrejmirtes
requested changes
Mar 18, 2025
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
This is very very valuable, but it needs two things:
- The new errors can be reported only with bleeding edge.
- The new code has to employ RuleLevelHelper. The idea is that "always wrong" like
intis always reported, "sometimes wrong" likeint|stringis reported on level 7+, nullable likestring|nullis reported on level 8+ and mixeds are reported on level 9+. Just use RuleLevelHelper like it's used in all the rules and it will be taken care of automatically.
ondrejmirtes
requested changes
Mar 18, 2025
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Also please do this in two separate PRs:
- Let the rules handle Expr as
$node->nameto continue the error-reporting. So that:
$a = 'Foo';
echo Foo::{$a}Is checked against a non-existent constant. This doesn't need bleeding edge.
- Introduce new reported errors that check
$ainFoo::{$a}to be a string. This needs bleeding edge and RuleLevelHelper.
Thank you.
Member
|
Also within those PRs add relevant regression tests for these issues: https://github.com/phpstan/phpstan-src/actions/runs/13923245791 (some of them might disappear once we do it for bleeding edge so it's nice to have this list now) |
Contributor
Author
|
Ok, I'll freeze this branch and submit some PRs. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve phpstan/phpstan#9475