Mark ob_*() functions has side-effects#3867
Closed
zonuexe wants to merge 1 commit intophpstan:1.12.xfrom
Closed
Conversation
Member
|
Please follow instructions here phpstan-src/resources/functionMetadata.php Lines 3 to 15 in 2fe4e0f |
2194c9d to
378afad
Compare
378afad to
4b080b5
Compare
Contributor
Author
|
The PhpStorm stub marks #[Pure(true)]
function ob_get_contents(): string|false {}
This is the same as the #2037 vs 2b5b317 conflict about According to the current semantics of PHPStan, all |
This was referenced Mar 13, 2025
Member
|
Not needed anymore thanks to #3880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve phpstan/phpstan#12577
All
ob_*()functions are impure.It's possible to implement state like
clearstatcache()in scopes, but it probably makes sense to just mark these as['hasSideEffects' => true]and leave it at that.