Support for numeric string in bc math#382
Merged
ondrejmirtes merged 7 commits intophpstan:masterfrom Nov 26, 2020
Merged
Conversation
3f113ff to
459c058
Compare
Member
|
Hi, thank you, you need to update the tests: it's |
aszenz
commented
Nov 26, 2020
| * @param FuncCall $functionCall | ||
| * @param Scope $scope | ||
| * @return NullType|StringType|UnionType | ||
| * @return NullType|Type|UnionType |
Contributor
Author
There was a problem hiding this comment.
I guess we can just use @return Type here since both NullType and UnionType extend Type.
Or is there a way to say tt's a String|AccessoryNumericStringType, the TypeCombinator::intersect function returns a generic Type though
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#4127