Add a test covering a hooked property in a readonly class#3809
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Feb 6, 2025
jakubtobiasz:readonly-classes-cannot-have-hooked-properties
Merged
Add a test covering a hooked property in a readonly class#3809ondrejmirtes merged 1 commit intophpstan:2.1.xfrom jakubtobiasz:readonly-classes-cannot-have-hooked-properties
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
jakubtobiasz:readonly-classes-cannot-have-hooked-properties
Conversation
Member
|
Thank you very much! BTW each item in the linked issue does not have to be a separate PR, you can do multiple items at once if they are related :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$node->isReadOnly()returnstruewhen a property lives inside a readonly class, so I've added only a simple test to existing test suite :).Fulfills
Readonly classes cannot have hooked properties(ref: phpstan/phpstan#12336)