Prevent declaring hooked properties as readonly#3803
Prevent declaring hooked properties as readonly#3803ondrejmirtes merged 4 commits intophpstan:2.1.xfrom jakubtobiasz:hooked-properties-cannot-be-readonly
Conversation
|
Also please do the same in the interface property rule, thank you. |
|
Hello @ondrejmirtes 👋🏼, I've covered what you asked for :). As I'm working on hooked properties and I see your list of |
|
I think the current way is better. It's easier to see what is and what isn't covered. Some rules apply to all properties so with your suggestion there would have to be some duplication too. |
|
Ok, so do you anything more from me in this PR or I can take a next one :D. |
|
I moved a piece of code for better readability (fdda36e) which means the error is reported regardless of |
|
Seems legit 🤔 |
|
Thank you! |
Fulfills
Hooked properties cannot be readonlyfrom phpstan/phpstan#12336 :)