Imagick::getConfigureOptions() returns array instead of string#3801
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Jan 30, 2025
Merged
Imagick::getConfigureOptions() returns array instead of string#3801ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
Conversation
ondrejmirtes
requested changes
Jan 30, 2025
resources/functionMap.php
Outdated
| 'Imagick::getCompression' => ['Imagick::COMPRESSION_*'], | ||
| 'Imagick::getCompressionQuality' => ['int'], | ||
| 'Imagick::getConfigureOptions' => ['string'], | ||
| 'Imagick::getConfigureOptions' => ['array'], |
Member
There was a problem hiding this comment.
Would be great to be more specific here, is it array<uppercase-string, string>?
Contributor
Author
There was a problem hiding this comment.
@ondrejmirtes I changed it here e92d478
It's not just uppercase strings.
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be fix https://phpstan.org/r/650952e7-9859-4db0-ae91-58b8ca25a1ef
See:
JetBrains/phpstorm-stubs#1707
https://phpimagick.com/Imagick/getConfigureOptions