Check that values passed to array_sum/product are castable to number#3658
Merged
ondrejmirtes merged 3 commits intophpstan:2.0.xfrom Nov 24, 2024
Conversation
0f33997 to
9702612
Compare
9702612 to
11a974f
Compare
ondrejmirtes
requested changes
Nov 23, 2024
Member
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11883
It's largely a copy-paste of
ParameterCastableToStringRule(#3132). I checked php-src and as far as I can tell this is the code that's used byarray_sum/array_productto convert objects to numbers. It seems to correspond toType::toNumber()in PHPStan.It seems that resource worked before PHP 8.3, but I'd report it anyway, since I can't imagine a scenario where you'd want
array_sum/array_productover resources: https://3v4l.org/lF7SE