Use a benevolent union type in openssl_cipher_iv_length#3582
Closed
stof wants to merge 1 commit intophpstan:1.12.xfrom
Closed
Use a benevolent union type in openssl_cipher_iv_length#3582stof wants to merge 1 commit intophpstan:1.12.xfrom
openssl_cipher_iv_length#3582stof wants to merge 1 commit intophpstan:1.12.xfrom
Conversation
This function returns `false` (and triggers a warning) only when the argument is an unknown algorithm, which is not something worth checking when using this function with a known algorithm.
ondrejmirtes
requested changes
Nov 5, 2024
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Nope, this should be handled more like mb_ functions are handled with mb_list_encodings. See MbFunctionsReturnTypeExtensionTrait.
Contributor
Author
|
I submitted another PR with the proper approach (and also applying it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function returns
false(and triggers a warning) only when the argument is an unknown algorithm, which is not something worth checking when using this function with a known algorithm.