Get rid of unnecessary instanceof self in ConstantArrayType#3542
Merged
ondrejmirtes merged 1 commit intophpstan:2.0.xfrom Oct 7, 2024
Merged
Get rid of unnecessary instanceof self in ConstantArrayType#3542ondrejmirtes merged 1 commit intophpstan:2.0.xfrom
instanceof self in ConstantArrayType#3542ondrejmirtes merged 1 commit intophpstan:2.0.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
Member
|
Thank you. |
Member
Contributor
Author
|
yes, will refrain from doing this next time. ah I saw you reverted it again, should I re-create the core change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of now unnecessary
instanceof selfinConstantArrayTypeby slightly improvingsliceArray()which made it possible to removereindex()completely :)Contains changes of #3406 and should be merged after that one came into 2.0.x. Should apply cleanly, if not I can update it of course.