This pull request has been marked as ready for review.

If I understand correctly

You are using numeric-string in case only numbers are used ?
But numbers like 1234 is considered as a numeric string lowercased. (Only things like 10E2 are not but I dont think there is uppercase letter in sha or md5)

So it's non-falsy&numeric&lowercase|non-falsy&lowercase
Which can be simplified to non-falsy&lowercase.

I dont think there is a benefit to specify that sometimes it's a fully numeric string

great feedback. I like the simplified version a lot more.

I am not yet used to thinking about numbers to be lowercase strings ;).

this also means we can do similar stuff in the hash() dynamic return type extension when $algo is a constant string known

Thank you!

@staabm I'm not familiar with sha256 ; should the return type be updated too ?

I am not familiar either.

Tested a few inputs on https://emn178.github.io/online-tools/sha256.html and it seems you are right

I am not familiar either.

Tested a few inputs on emn178.github.io/online-tools/sha256.html and it seems you are right

I'll do the PR as soon as I have confirmation this function really exists (cf my interrogation phpstan/phpstan#12048 (comment))