Fix slow enum-union with lots of cases#2985
Merged
ondrejmirtes merged 4 commits intophpstan:1.10.xfrom Mar 22, 2024
Merged
Conversation
Contributor
Author
not sure where to put the regression test, since we need a composer.json/lock. in the past we used should I do a end-2-end test? if so, how/where to put a "timeout" for it? alternatively I can try to reduce the existing test to something without external composer dependencies |
Contributor
Author
|
(added regression test) |
| if ($types[$i] instanceof StringType && !$types[$i] instanceof ClassStringType) { | ||
| $hasGenericScalarTypes[ConstantStringType::class] = true; | ||
| } | ||
| $enumCases = $types[$i]->getEnumCases(); |
Contributor
There was a problem hiding this comment.
If the issue is with getEnumCases be slow.
Shouldn't be introduced a new method isSomething, implemented by all types in order to avoid the error message
Doing instanceof PHPStan\\\\Type\\\\Enum\\\\EnumCaseObjectType is error\\-prone and deprecated\\
?
Then
if ($types[$i]->isSomething()->yes()) {
Contributor
Author
There was a problem hiding this comment.
Not sure its worth a new type-method just for this bottleneck
Member
|
Thank you! |
This was referenced Mar 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10772
this effectively reverts 0a39b42 but fixes a nasty perf problem
the reproducer of #10772 took >2 minutes before this change and finishes instantly after it
Todo: regression test