Fixed incorrect return type of PDO::quote()#2926
Closed
rasmus0201 wants to merge 1 commit intophpstan:1.11.xfrom
Closed
Fixed incorrect return type of PDO::quote()#2926rasmus0201 wants to merge 1 commit intophpstan:1.11.xfrom
rasmus0201 wants to merge 1 commit intophpstan:1.11.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
Contributor
|
Friendly ping @ondrejmirtes you might have missed this "easy" PR to review or do you also want a non-regression test for such changes ? |
Member
|
I didn't merge this yet because I'm not sure about this change. The documentation states:
So a benevolent union type might be the better choice here - Also the usage of this function at all is not recommended in favor of prepared statements. That's why I didn't rush to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#10512