Update Locale signatures#2880
Merged
ondrejmirtes merged 2 commits intophpstan:1.11.xfrom May 30, 2024
Merged
Conversation
Contributor
Author
|
Not sure why this is failing: https://github.com/phpstan/phpstan-src/actions/runs/7568063545/job/20608638825?pr=2880 |
ondrejmirtes
requested changes
Jan 22, 2024
Member
|
That build failure is not the fault of this PR. |
Member
|
Also please get rid of the merge commit, the history should be linear (use rebase instead). |
71cbfc8 to
8b59c05
Compare
Contributor
Author
|
I think this should do it 😄 |
ondrejmirtes
requested changes
Feb 20, 2024
Member
There was a problem hiding this comment.
If you make return types more specific it can be put into functionMap.php, not bleeding edge. Only more specific parameter types need to be put into bleeding edge.
3ab621b to
4e11792
Compare
Member
|
Thank you. |
|
Did this fix phpstan/phpstan#7855 ? |
This was referenced May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about documenting all optional parameters of
Locale::composeLocale()as it has no effect when introducing non-documented parameters to the function, but I've reviewed all the functions, even the undocumented ones and AFAIK these are the correct signatures 😊