Narrow Closure::bind $newScope param#2817
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
|
This pull request has been marked as ready for review. |
You could use NodeScopeResolverTest to check your assumptions |
0d0e823 to
91f403b
Compare
ondrejmirtes
left a comment
There was a problem hiding this comment.
Please do not rename parameter names
91f403b to
b02eeb5
Compare
Did you mean |
|
In these tests you can only assert types. If you need to assert error messages you have to go with a rule-test |
|
@ondrejmirtes I can added a test to |
ondrejmirtes
left a comment
There was a problem hiding this comment.
Add whatever test you think is your best idea, I'll review if it's okay or not.
b02eeb5 to
dca3393
Compare
8a4a3c6 to
ff35e71
Compare
ff35e71 to
eac2b66
Compare
|
This pull request has been marked as ready for review. |
|
Thank you! |
Same change as in JetBrains/phpstorm-stubs#1591.
Am I right the phpstorm-stubs are used for
Puremetadata only?The default type of
newScopearg is'static'which is not subtype ofclass-string, does phpstan imply that from the real reflection?