Support for phpstan and psaml prefixes on @method#279
Closed
bastien-phi wants to merge 3 commits intophpstan:masterfrom
bastien-phi:add-prefixes-method
Closed
Support for phpstan and psaml prefixes on @method#279bastien-phi wants to merge 3 commits intophpstan:masterfrom bastien-phi:add-prefixes-method
bastien-phi wants to merge 3 commits intophpstan:masterfrom
bastien-phi:add-prefixes-method
Conversation
Member
|
Hi, the diff seemed weird to me, and yes, the CS build tells me you switched from tabs to spaces: https://github.com/phpstan/phpstan-src/pull/279/checks?check_run_id=881533402 Please fix that first so I can do the review. |
Author
|
This should be better. Forgot to check cs... Sorry about that ! |
Author
|
Closed in favored of #302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#2976
Not sure if there are enough test or about file naming.