Skip to content

Ability to disable implicit throws in tests #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 3 commits into from
Aug 18, 2023
Merged

Ability to disable implicit throws in tests #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9593768
Ability to disable implicit throws in tests
janedbal Aug 18, 2023
a3ca4f5
Remove useless config
janedbal Aug 18, 2023
4bfe4ca
allow older php
janedbal Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Testing/RuleTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private function getAnalyser(): Analyser
$this->shouldPolluteScopeWithAlwaysIterableForeach(),
[],
[],
true,
self::getContainer()->getParameter('exceptions')['implicitThrows'],
$this->shouldTreatPhpDocTypesAsCertain(),
self::getContainer()->getParameter('featureToggles')['detectDeadTypeInMultiCatch'],
);
Expand Down
38 changes: 38 additions & 0 deletions tests/PHPStan/Rules/Exceptions/AbilityToDisableImplicitThrowsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php declare(strict_types = 1);

namespace PHPStan\Rules\Exceptions;

use PHPStan\Rules\Rule;
use PHPStan\Testing\RuleTestCase;
use function array_merge;

/**
* @extends RuleTestCase<CatchWithUnthrownExceptionRule>
*/
class AbilityToDisableImplicitThrowsTest extends RuleTestCase
{

protected function getRule(): Rule
{
return new CatchWithUnthrownExceptionRule();
}

public function testRule(): void
{
$this->analyse([__DIR__ . '/data/ability-to-disable-implicit-throws.php'], [
[
'Dead catch - Throwable is never thrown in the try block.',
17,
],
]);
}

public static function getAdditionalConfigFiles(): array
{
return array_merge(
parent::getAdditionalConfigFiles(),
[__DIR__ . '/data/ability-to-disable-implicit-throws.neon'],
);
}

}
3 changes: 3 additions & 0 deletions tests/PHPStan/Rules/Exceptions/data/ability-to-disable-implicit-throws.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
parameters:
exceptions:
implicitThrows: false
25 changes: 25 additions & 0 deletions tests/PHPStan/Rules/Exceptions/data/ability-to-disable-implicit-throws.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php declare(strict_types = 1);

namespace AbilityToDisableImplicitThrows;

class HelloWorld
{
public function sayHello(callable $c): void
{
try {
$c();
} catch (\Throwable $e) { // no error here

}

try {
$this->method();
} catch (\Throwable $e) { // Dead catch - Throwable is never thrown in the try block.

}
}

public function method(): void
{
}
}