Closed
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
mad-briller
reviewed
Jun 16, 2023
| } | ||
|
|
||
| public function supportsLessOverridenParametersWithVariadic(): bool | ||
| public function supportsLessOverriddenParametersWithVariadic(): bool |
Contributor
There was a problem hiding this comment.
this is a public api that extension authors can use so this would be a bc-break
Contributor
Author
There was a problem hiding this comment.
So I should revert it?
Member
|
I'm interested only in some of the changes, not all of them. I definitely not want any changes in Please send a PR for one file (or related change) at a time. Wait for a PR to be reviewed and merged, before sending the next one. Thanks for understanding. |
This was referenced Jun 16, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool used: https://github.com/crate-ci/typos